Change in vdsm[master]: Add some base functions to vdsm-tool
wenyi at linux.vnet.ibm.com
wenyi at linux.vnet.ibm.com
Wed Jun 13 14:00:27 UTC 2012
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm-tool/base.py
Line 43: def call(*args, **kwargs):
Sounds good.
Line 64: subprocess.call(['echo', '-n', msg])
Actually not. 'echo -n msg' prints msg without '\n', while 'print' prints msg with '\n'
--
To view, visit http://gerrit.ovirt.org/5264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1be737adce28e9ca532aa454e7f0a060947589e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list