Change in vdsm[master]: VM.create: Make readonly optional for disk devices

agl at us.ibm.com agl at us.ibm.com
Tue Jun 12 21:51:14 UTC 2012


Adam Litke has uploaded a new change for review.

Change subject: VM.create: Make readonly optional for disk devices
......................................................................

VM.create: Make readonly optional for disk devices

When processing disk devices to create a libvirt xml file, the current code
assumes that the 'readonly' attribute is always present.  If it's missing,
VM.create will fail with an AttributeError.  When describing disks, 'readonly'
is typically an optional parameter that defaults to False if not specified.  In
fact, this is what getConfDrives already does for legacy drives.  Right now,
there is only one place that assumes readonly is present.  Change it to check
for the attribute first.

Signed-off-by: Adam Litke <agl at us.ibm.com>
Change-Id: I83b43ef02b38091a8b3bfd1a9d0485e3b04323c3
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/5298/1
--
To view, visit http://gerrit.ovirt.org/5298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83b43ef02b38091a8b3bfd1a9d0485e3b04323c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>


More information about the vdsm-patches mailing list