Change in vdsm[master]: BZ#830486 - Allow to change network according the diffs from...

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Jun 11 10:09:58 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#830486 - Allow to change network according the diffs from previous state
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1066:                     # bond information, because only this network has a changes
we need this change because the engine starts to pass only changes from previous network map.
Now, let's assume that you have network defined on top of bond and now you changed only network parameter (let say MTU) but nothing for bond. In this case you will get in parameters only network's part without bond itself. 
Therefore, first we can't rely on 'bondings' dict because it's empty (bond wasn't changed) and second anyway we have nothing to do with bond (again it wasn't changed)

--
To view, visit http://gerrit.ovirt.org/5211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ece66a351576d5789a8968ccda9e67f423b860c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list