Change in vdsm[master]: Iterates over delete candidates networks only once

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Mon Jun 11 09:05:03 UTC 2012


Shu Ming has posted comments on this change.

Change subject: Iterates over delete candidates networks only once
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Please see comments in line.

....................................................
File vdsm/configNetwork.py
Line 1027:             for network, networkAttrs in networks.items():
Please explain why you use items() instead of iteritems() in original code.

--
To view, visit http://gerrit.ovirt.org/5204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec45c1cb3d76a70555e256f96c983e13a0518cbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list