Change in vdsm[master]: Changing origin of memShared stats to /sys/kernel/mm/ksm/pag...

danken at redhat.com danken at redhat.com
Fri Jun 8 19:30:36 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Changing origin of memShared stats to /sys/kernel/mm/ksm/pages_sharing
......................................................................


Changing origin of memShared stats to /sys/kernel/mm/ksm/pages_sharing

Currently, _memShared() is calculated adding the shared pages value
(3rd field) from /proc/<VM_PID>/statm file from all running VMs and
converting to bytes through PAGE_SIZE value. The KSM module shipped
in RHEL5 is a different version from the KSM module found on the latest
upstream kernel versions. Newer features, such as exporting statistics
on the /sys filesystem, that are implemented upstream are not in the
version shipped in this release. Starting from kernel 2.6.10, statm
shared field was changed, making _memShared() imprecise about KSM
shared pages.
This patch take advantage of /sys statistics of KSM in current
releases to correct _memShared() results.

Change-Id: Ic8b5b366b8668cf74b04d1089e6e515e93c0f746
Signed-off-by: Amador Pahim <apahim at redhat.com>
---
M AUTHORS
M vdsm/API.py
M vdsm/ksm.py
3 files changed, 13 insertions(+), 16 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Xu He Jie: Looks good to me, but someone else must approve
  Amador Pahim: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8b5b366b8668cf74b04d1089e6e515e93c0f746
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list