Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Jun 7 05:20:03 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Properly parse configurations in function "do_create" in vdsClient
......................................................................


Patch Set 1:

Two example nested values:

drive=pool:3ace0f74-a9fa-11e1-bb33-00247edb4743,domain:1de3f4e2-a9f9-11e1-9956-00247edb4743,image:8230cd4a-aa1b-11e1-970c-00247edb4743,volume:b9e163b6-aa1c-11e1-94f6-00247edb4743,boot:true,format:cow

cpuPinning={0:0,1:1}

do_create function is for creating a VM. Before create it, we must setup storage domain, pool and image. And selinux can prevent qemu from visiting the image. If you have problem creating VM, I can help.

There is another simple way to test it without actually creatung a VM. You can just add a line "pp.pprint(params)" at the bottom of the function, then examine if the printed result is right.

--
To view, visit http://gerrit.ovirt.org/5093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd6801a6d4de3f51fc7d1e0f744bcb2c71d422f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list