Change in vdsm[master]: Change storageServer to handle numeric connection values

danken at redhat.com danken at redhat.com
Wed Jun 6 19:09:48 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Change storageServer to handle numeric connection values
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 100: def _addIntegerOption(options, key, value):
I would've called it _appendIntegerOption, but that's fine.

--
To view, visit http://gerrit.ovirt.org/5062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>


More information about the vdsm-patches mailing list