Change in vdsm[master]: Change storageServer to parse some params as strings

abaron at redhat.com abaron at redhat.com
Wed Jun 6 08:20:53 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Change storageServer to parse some params as strings
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 241:         options.append("timeo=%s" % timeout)
the alternative is to do: 
int(timeout)
which would also verify that the parameter passed is ok.
Even better, can just change the xmlrpc bindings to convert it to int

--
To view, visit http://gerrit.ovirt.org/5062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>


More information about the vdsm-patches mailing list