Change in vdsm[master]: Add passwd command to vdsm-tool

lilei at linux.vnet.ibm.com lilei at linux.vnet.ibm.com
Wed Jun 6 06:58:32 UTC 2012


Lei Li has posted comments on this change.

Change subject: Add passwd command to vdsm-tool
......................................................................


Patch Set 9: (2 inline comments)

....................................................
File vdsm-tool/passwd.py
Line 35:         f = open(constants.P_VDSM_LIBVIRT_PASSWD, 'r')
Dan' comment about pythonic is 'it is more pythonic and less raceful to try to open, and then catch the IOError'.
I guess you mean should use 'with open' to be more pythonic.
I think 'with open' is necessary to avoid close issue, but it is not an 'must' thing, sometime it depends the context.

Line 42:             stderr=subprocess.PIPE, close_fds=True)
Thanks for the link, and what's your point?

--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list