Change in vdsm[master]: Fix "unknown device" issue for balloon device

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Jun 5 07:26:35 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Fix "unknown device" issue for balloon device
......................................................................


Patch Set 2: Verified

Without this fix, the balloon device is recognized as an unknown device when it parse underlying information:
two balloon entries are seen in vm'conf:
{'device': 'memballoon', 'specParams': {'model': 'virtio'}, 'type': 'balloon', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}}, 
and 
{'device': '', 'alias': 'balloon0', 'type': 'memballoon', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}}


With this fix, the balloon entry in vm's conf is updated well:
{'device': 'memballoon', 'specParams': {'model': 'virtio'}, 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'type': 'balloon', 'alias': 'balloon0'}

So change it to verified.

--
To view, visit http://gerrit.ovirt.org/3901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9c371d1f3d90521cc4bfb9516a0bb979843f52
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list