Change in vdsm[master]: Replace username and file location for SASL by constants

danken at redhat.com danken at redhat.com
Tue Jun 5 06:38:10 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Replace username and file location for SASL by constants
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/constants.py.in
Line 65: P_VDSM_FILE = '/etc/pki/vdsm/keys/libvirt_password'
this should be 

  	P_VDSM_LIBVIRT_PASSWD = P_VDSM_KEYS + 'libvirt_password'

the name you've chosen is not very descriptive...

--
To view, visit http://gerrit.ovirt.org/5037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list