Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

fsimonce at redhat.com fsimonce at redhat.com
Mon Jun 4 09:34:42 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: BZ#784931 - Restore SD.validate() semantics.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 752:         lvm.chkVG(self.sdUUID)
What I meant is that this is a caching mechanism as much as selftest. Once you tested the state (and you believe you got the "true" state), it might then became unreachable. This doesn't look like a fix, it's just make it more difficult to happen (and to verify).

--
To view, visit http://gerrit.ovirt.org/4955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I423777deafc4e1d9186054ec33f2744712065512
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list