Change in vdsm[master]: remove '/var/log/core' from fedora

Xu He Jie xuhj at linux.vnet.ibm.com
Mon Jun 4 01:37:28 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: remove '/var/log/core' from fedora
......................................................................


Patch Set 3: (4 inline comments)

Hi, Dan, I found this patch too complex, I will separate it. I guess submit a topic branch will more clear. Because I guess other distribution(Like Debian) doesn't like /var/log/core too, so I add config param for core dump. But I prefer remove this config param too if this really not worth to do. It will make code simple and clear. And Thanks you and Wenyi review such complex patch!

....................................................
File vdsm-tool/configureCoreDump.py
Line 35:             os.mkdir(constants.P_VDSM_CORE_DUMP)
Yeah, you are right, Thanks, Wenyi

Line 47:         raise
Done

....................................................
File vdsm/vdsmd.init.in
Line 498:     vdsm-tool configure-core-dump
I only find libvirt use this env variable. But we already set this config to libvirt config file. I guess this unnecessary. Is this used by vdsm?

....................................................
File vdsm/vdsm-logrotate-coredump
Line 1: #!/bin/bash
It should be sh, I will fix it.

--
To view, visit http://gerrit.ovirt.org/4348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I594b5aa2ecaad1b1a268fa231a5769ef437ec75e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <matrixs.zero at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list