Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Jun 3 12:48:11 UTC 2012


Eduardo has posted comments on this change.

Change subject: Fix attachSD and masterMigrate for domain version 3
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 859:             if not newmsd.hasVolumeLeases():
Since mixed pools are forbidden we can assume that the newmsd is using the same safelease as curmsd.

Line 949:             dom.releaseHostId(self.id)
Why are you releasing your Host ID?

--
To view, visit http://gerrit.ovirt.org/4037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe26891b2b9d5c4a34876115d49f14725b476f99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list