Change in vdsm[master]: Automatic reconnection to the Storage Pool

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Jun 3 08:31:01 UTC 2012


Eduardo has posted comments on this change.

Change subject: Automatic reconnection to the Storage Pool
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 323:                     self._connectStoragePool(spUUID, None, None, None, None)
Since this is the only entry in which pool parameters are taken from the saved state, IMHO is better to call getStoredPoolInformation here, split the _connectStoragePooll function and remove the option of passing None as MSD or version.

Line 822:                             masterVersion, options=None):
Removing None parameters support simplifies this function very much.
options parameter is unused and this is an internal function. Please remove.

--
To view, visit http://gerrit.ovirt.org/4516
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I682a12deff90dd78bb31b7368c003796ed241cd9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list