Change in vdsm[master]: remove '/var/log/core' from fedora

danken at redhat.com danken at redhat.com
Sat Jun 2 22:34:35 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: remove '/var/log/core' from fedora
......................................................................


Patch Set 3: (2 inline comments)

wow. this is a bit too complex for me. could you do this step-by-step, patch-by-patch?

I do not think that we need a means to control the /var/log/core path. At least not at first stage. We should just control whether to create it (rhel) or not (fedora). imho configuring core dumps does not merit a configure param.
choosing the default of core_dump_enable may also be done in a separate patch.

splitting the logrotate rules to different is a good idea - but please do in a separate patch.

....................................................
File vdsm/vdsmd.init.in
Line 498:     vdsm-tool configure-core-dump
are you sure `deamon` no longer needs

  DAEMON_COREFILE_LIMIT=unlimited

(for vdsm crashes)?

....................................................
File vdsm/vdsm-logrotate-coredump
Line 1: #!/bin/bash
why require bash, suddenly?

--
To view, visit http://gerrit.ovirt.org/4348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I594b5aa2ecaad1b1a268fa231a5769ef437ec75e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <matrixs.zero at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list