Change in vdsm[master]: API: Add formal definition for disk types

danken at redhat.com danken at redhat.com
Sat Jun 2 03:17:07 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: API: Add formal definition for disk types
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1812:         :type diskType: int
yes, it is an int, but it's python's best approximation of an enum.

I think it would be nicer if you put here (and fileVolume)

  :class:`API.Image.DiskTypes`

--
To view, visit http://gerrit.ovirt.org/4957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list