Change in vdsm[master]: add vdsm-tool verb configure-core-dump

Xu He Jie xuhj at linux.vnet.ibm.com
Fri Jul 27 06:21:19 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: add vdsm-tool verb configure-core-dump
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm-tool/configureCoreDump.py
Line 30:     if not config.getboolean('vars', 'core_dump_enable'):
Done

Line 38:     with open(SYS_CORE_PATTERN, 'w+') as sysCorePattern:
It looks need write something to modify /etc/sysctl.d/vdsm at runtime. Thanks for the review!

--
To view, visit http://gerrit.ovirt.org/5154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed530a35339e1e2a366a61f1bce1a8c9e71db53
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list