Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Jul 26 01:32:34 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: make vdsm/libvirtvm.py PEP 8 clean
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 578:         (self.dom
I agree. We also need eliminate that "xml.minidom.blah().blah()...". It occurs several times. That call chain is not a plain chain, each dot is to call a method in a deeper level.

--
To view, visit http://gerrit.ovirt.org/6561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list