Change in vdsm[master]: Added user verification before running VDSM.

danken at redhat.com danken at redhat.com
Wed Jul 25 11:51:38 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added user verification before running VDSM.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/vdsm
Line 93: def VerifyUser():
function names should begin in lower case.

this function should be _private

Line 98:         print "VDSM failed to start: running user is not 'vsdm', trying to run from user", user     
trailing whitespace,  too long line.

Line 101:         for cur_usr in grp.getgrnam("kvm").gr_mem:
that's a complex way of writing

  if 'vdsm' in grp.getgrnam("kvm").gr_mem:

Line 112:       exit(1)
use constant 4 space indentation.

--
To view, visit http://gerrit.ovirt.org/6610
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I401430a8031894c50a9c9126672b6a4cfeb25130
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list