Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

gpadgett at redhat.com gpadgett at redhat.com
Tue Jul 24 00:15:54 UTC 2012


Greg Padgett has posted comments on this change.

Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................


Patch Set 5: (4 inline comments)

Dan, thanks.  I uploaded patch set 6, which addresses some of the issues.  I'll mark it -1 as a WIP while looking into a storage domain alert.

....................................................
File vdsm/storage/storageServer.py
Line 252:             options = ("".join(config.get('irs', 'nfs_mount_options').split())).split(",")
Done

Line 253:             self._log.warning("Using deprecated nfs_mount_options parameter "
Thanks for the idea, I am looking into it.

Line 262:                 parts = opt.split("=")
True, even the default options of "soft,nosharecache" do not follow the key=value convention.  However IIUC, Python's str.split() will happy return a one-element list if it splits a string that contains no separator.  (AFAICT, The documentation is silent on this particular point, but it is corroborated by the legality of maxsplit=0.)

Line 278:         self._timeout = opts['timeo'];
Yes, that reflex makes for some gross Python code, my apologies.  Fixed all 5 places.

--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list