Change in vdsm[master]: Uniform the block and file volume methods

fsimonce at redhat.com fsimonce at redhat.com
Mon Jul 23 18:59:01 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Uniform the block and file volume methods
......................................................................


Patch Set 23: (1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 674:         return (self.sdUUID, self.getMetaOffset())
Why? What did you expect here? All the BlockVolume methods were using the sdUUID and the offset to identify the metadata. Here I'm just making it explicit. Anyway this is an internal opaque object (only BlockVolume knows what it represents).

--
To view, visit http://gerrit.ovirt.org/3683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list