Change in vdsm[master]: BZ#837836 Change tpgt variable to identically None

danken at redhat.com danken at redhat.com
Mon Jul 23 18:24:46 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#837836 Change tpgt variable to identically None
......................................................................


Patch Set 2: I would prefer that you didn't submit this

I'd be happier if the commit message had include a description of what is removed, why, and why we're not breaking an API by this.

I found a joyous comment by Saggi in the cited bug, not I am personally content. Yet the commit message should be more descriptive - maybe you can rephrase Saggi's text to a language that we mortals understand.

"""
This is not a but, someone sent a string in the portal field (which is actually tpgt)

Engine internally never does this and sending this is wrong anyway.

The real issue is that the parameter name has been confusing all this time until I decided to fix it.

This is not a bug, the bug was that it worked in the first place.
"""

--
To view, visit http://gerrit.ovirt.org/6367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f368ce449e9cd51a06398e54d9b5ffbec20e842
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list