Change in vdsm[master]: Uniform the block and file volume methods

smizrahi at redhat.com smizrahi at redhat.com
Mon Jul 23 17:14:42 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Uniform the block and file volume methods
......................................................................


Patch Set 23: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 674:         return (self.sdUUID, self.getMetaOffset())
Why do you return the sdUUID? Seems highly irregular

--
To view, visit http://gerrit.ovirt.org/3683
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list