Change in vdsm[master]: Basic tests for the tc module

roman at fenkhuber.at roman at fenkhuber.at
Mon Jul 23 06:08:55 UTC 2012


Roman Fenkhuber has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 11:

I think testing for the three or four modules in the testcase is the wrong place for two reasons:
 - my test does not depend on these modules, it is the tc module itself.
 - testing for modules directly can lead to false positive, as a custom kernel could have built in the functionality.

Isn't it better to run a script like 
 brctl addbr lala
 tc qdisk add dev lala ingress

by autotools which would tell you that the tc modules are a direct dependency?

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list