Change in vdsm[master]: Sort the pep8 whitelist list

danken at redhat.com danken at redhat.com
Sat Jul 21 21:52:11 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Sort the pep8 whitelist list
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File Makefile.am
Line 60: 	vdsm/hooks.py \
and much worse - you're using non-C locale for sorting. I think the difference between a slash and an underscore is quite significant.

--
To view, visit http://gerrit.ovirt.org/6246
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86982eb9eb0ce2ae6a671af0be209f0444421e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list