Change in vdsm[master]: BZ#831528, BZ#834008, BZ#829037 - Fix validation for inter-n...

asegurap at redhat.com asegurap at redhat.com
Fri Jul 20 13:41:42 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: BZ#831528, BZ#834008, BZ#829037 - Fix validation for inter-networks compatibility
......................................................................


Patch Set 3: (1 inline comment)

I might be wrong in my assumptions and/or my netinfo might be faulty, but my impression is that the invokation I put should get an exception of used nic. However, this is not the case.

....................................................
File vdsm/configNetwork.py
Line 601: 
The case I mentioned (bond with nic already in use by a bridge) is not captured in the check you mention when you feed _addNetwork the following data:

        _netinfo = {
                'networks': {
                    'fakent': {'interface': 'fakeint', 'bridged': False},
                    'fakebrnet': {'bridge': 'fakebr', 'bridged': True, 'ports':
                        ['eth0', 'eth1']},
                    'fakebrnet1': {'bridge': 'fakebr1', 'bridged': True,
                        'ports': ['bond00']}
                    },
                'vlans': {
                    'fakevlan': {
                        'iface': 'eth3',
                        'addr': '10.10.10.10',
                        'netmask': '255.255.0.0',
                        'mtu': 1500
                        }
                    },
                'nics': ['eth0', 'eth1', 'eth3', 'eth4', 'eth5', 'eth6'],
                'bondings': {
                    'bond00': {
                        'slaves': ['eth5', 'eth6']
                        }
                    }
                }

# Request a bond for eth0 and eth1 that are already in fakebrnet.
_addNetwork(_netinfoIns, 'test', None, 'bond0', ['eth0', 'eth1'], None, None, None, None)

--
To view, visit http://gerrit.ovirt.org/6384
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1de66dea8cf73ecdde8e6651d4a2209be120a707
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list