Change in vdsm[master]: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Fri Jul 20 08:16:36 UTC 2012


Shu Ming has posted comments on this change.

Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

I think it will better to have some code to check the version of VDSM like:

if (get_vdsm_ver() < 4.0)
    self.log("Warning..."
else
    raise exception_not_supported

--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list