Change in vdsm[master]: faqemu: use domain type 'qemu' instead of the emulator wrapp...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jul 19 01:48:39 UTC 2012


Mark Wu has posted comments on this change.

Change subject: faqemu: use domain type 'qemu' instead of the emulator wrapper
......................................................................


Patch Set 1:

The kvm availability checking was added in recent libvirt vesion(tags/v0.9.10-rc1~225). That doesn't exist in rhel6.
That's why no problem found when you run it on rhel6 host.
I am not sure what problem my patch will cause on rhel6 host. I will give it a try when I have a rhel6 setup.

BTW, I am impressed by the high quality of libvirt commit message again. I am going to read the doc
http://berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/
again.

Please see the details:

commit 32f63e912d3bef42a7fa70a0f2d5b04b98afe936
Author: Laine Stump <laine at laine.org>
Date:   Mon Jan 9 14:54:14 2012 -0500

    qemu: check for kvm availability before starting kvm guests
    
    This *kind of* addresses:
    
      https://bugzilla.redhat.com/show_bug.cgi?id=772395
    
    (it doesn't eliminate the failure to start, but causes libvirt to give
    a better idea about the cause of the failure).
    
    If a guest uses a kvm emulator (e.g. /usr/bin/qemu-kvm) and the guest
    is started when kvm isn't available (either because virtualization is
    unavailable / has been disabled in the BIOS, or the kvm modules
    haven't been loaded for some reason), a semi-cryptic error message is
    logged:
    
      libvirtError: internal error Child process (LC_ALL=C
      PATH=/sbin:/usr/sbin:/bin:/usr/bin /usr/bin/qemu-kvm -device ? -device
      pci-assign,? -device virtio-blk-pci,? -device virtio-net-pci,?) status
      unexpected: exit status 1
    
    This patch notices at process start that a guest needs kvm, and checks
    for the presence of /dev/kvm (a reasonable indicator that kvm is
    available) before trying to execute the qemu binary. If kvm isn't
    available, a more useful (too verbose??) error is logged.

git name-rev 32f63e912d3bef42a7fa70a0f2d5b04b98afe936
32f63e912d3bef42a7fa70a0f2d5b04b98afe936 tags/v0.9.10-rc1~225

--
To view, visit http://gerrit.ovirt.org/6391
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd732d58a81977c1a2473485db92cd1787260e08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list