Change in vdsm[master]: Bz#839919 remoteFileHandler.py: Add storage into python path

danken at redhat.com danken at redhat.com
Wed Jul 18 16:41:26 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Bz#839919 remoteFileHandler.py: Add storage into python path
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Playing with sys.path deep inside a python application is quite evil.

If we must always hack it, why not use PYTHONPATH?

(I'm not happy about both options...)

--
To view, visit http://gerrit.ovirt.org/6354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id23c3d0be6eb2e2212172613ea8f3b0c58edce06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list