Change in vdsm[master]: BZ#840386: vms with shared disk will pause...

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Jul 18 10:09:09 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#840386: vms with shared disk will pause...
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

Look at my comment inside

....................................................
File vdsm/libvirtvm.py
Line 1058:         if  utils.tobool(self.shared):
Eli, just don't forget that you MUST to send 'share' not only for disks, but for cdrom and floppy too.

or you need to check hasattr for it.

--
To view, visit http://gerrit.ovirt.org/6283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82714a3a4fd86184b8ed48ef33ce69d0640d96ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list