Change in vdsm[master]: Refactored configWriter add methods for code reuse.

danken at redhat.com danken at redhat.com
Tue Jul 17 12:47:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Refactored configWriter add methods for code reuse.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I just love context managers, but I do not think this is the right solution this time.

A sign for this is the non-pronunceable name bupWrChmod(

The functions that you touch are using multiple write() actions, which is pretty silly. They should all build a string and pass it to a simple function (writeConfFile() ?) that does a single write().

--
To view, visit http://gerrit.ovirt.org/6366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7582950ae68731c71785b020330b7d207ed43aed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list