Change in vdsm[master]: Unify the volume creation code in volume.create

fsimonce at redhat.com fsimonce at redhat.com
Mon Jul 16 13:02:48 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Unify the volume creation code in volume.create
......................................................................


Patch Set 22: (3 inline comments)

....................................................
File vdsm/storage/volume.py
Line 405:             misc.validateUUID(argValue, argName, argAllowBlank)
Done

Line 443:                 size = volParent.getSize()
Good. I'd use 0 as special size to use the parent's size (I think it's already compatible with the current engine). If instead the size is specified we'll use it. This also solves the problem of creating live snapshots without looking at the qcow header and at the metadata (possible mismatch).

Line 486:             if dom.hasVolumeLeases():
Done

--
To view, visit http://gerrit.ovirt.org/3627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list