Change in vdsm[master]: Basic tests for the tc module

danken at redhat.com danken at redhat.com
Mon Jul 16 12:28:04 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/tcTests.py
Line 173:         self.tap0.arpProxyFor("192.168.3.2")
ok, I was not aware of the need to add the tap device to the bridge.

btw, a cleaner test could have avoided ip addresses completely, using layer-2-only arping or something like that. we can avoid this for a while.

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>


More information about the vdsm-patches mailing list