Change in vdsm[master]: Basic tests for the tc module

danken at redhat.com danken at redhat.com
Mon Jul 16 09:21:36 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File tests/tcTests.py
Line 83: def _listenOnDevice(fd):
do you really need more than one read/write?

a tight loop is clearly unacceptable.

Line 166:     tap0 = _Tap()
if you think the test needs explanation - that's what docstrings are for.

Line 173:         self.tap0.arpProxyFor("192.168.3.2")
I still do not understand why you need the tap device. Is sending the ping directly into the bridge is not enough?

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list