Change in vdsm[master]: Basic tests for the tc module

roman at fenkhuber.at roman at fenkhuber.at
Sun Jul 15 12:38:07 UTC 2012


Roman Fenkhuber has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 2: (3 inline comments)

Thank you for your feedback. I added the mirroring test and also put a few general questions in the patch comments.

....................................................
File tests/tcTests.py
Line 37: EXT_TCPDUMP = "/usr/sbin/tcpdump"
Is it ok to set the paths to the tools here (because it is just for a test), or shall they be integrated in autoconf and constants.py.in?

Line 104: class _Tun():
Using tap or tun devices was the only way I could think of testing mirroring without real network devices. I do not just create a tun device with ip, because in recent kernel versions you also have to access the tun device to bring it really up.

Does anyone know a better solution?

Line 140:         self.tun0.initTun("192.168.3.1/24")
you said, better no ifconfig, but is it ok to use ip only in this testmodule?

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>


More information about the vdsm-patches mailing list