Change in vdsm[master]: skip gluster test if vdsm-gluster rpm is not installed

danken at redhat.com danken at redhat.com
Fri Jul 13 10:05:58 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: skip gluster test if vdsm-gluster rpm is not installed
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/gluster_cli_tests.py
Line 35:     def setUp(self):
why do you need anything more than a

 if no gcli in globals(): raise SkipTest(vdsm-gluster not found)

here? wouldn't it work just as well?

--
To view, visit http://gerrit.ovirt.org/5915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ee0e5b6b550daa2506ac8192ffa8119ca40585
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list