Change in vdsm[master]: skip gluster test if vdsm-gluster rpm is not installed

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri Jul 13 01:34:46 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: skip gluster test if vdsm-gluster rpm is not installed
......................................................................


Patch Set 8: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File tests/gluster_cli_tests.py
Line 22: try:
Consider add comment for this line like:

# If the test is run under the installed vdsm, vdsm-cluster may not be always installed, so just ignore the exception.
# In the individual test, use 'TestCaseBase.checkLocalModule("gluster")' to guarantee gluster is imported in local test or skip if not installed when in the installed tree test.

....................................................
File tests/main.py
Line 27:     from gluster import exception as gluster_exception
Consider add comment for this line like:

# If the test is run under the installed vdsm, vdsm-cluster may not be always installed, so just ignore the exception.
# In the individual test, use 'TestCaseBase.checkLocalModule("gluster")' to guarantee gluster is imported in local test or skip if not installed when in the installed tree test.

--
To view, visit http://gerrit.ovirt.org/5915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ee0e5b6b550daa2506ac8192ffa8119ca40585
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list