Change in vdsm[master]: vdsmd: Don't keep the temporary file generated by configurin...

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Thu Jul 12 19:11:16 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: vdsmd: Don't keep the temporary file generated by configuring libvirt
......................................................................


Patch Set 1: No score

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 279:             -e "/$by_vdsm/d" "$@"
I make a file sed.txt as follow

$ ls -l sed.txt

-rw-rw-rw-. 1 root root 5 Jul 13 02:54 sed.txt

after I execute sed command without --copy,  the owner of this file will change.

$ sed -i  -e '/test/d' sed.txt

$ ls -l sed.txt

-rw-rw-rw-. 1 shhfeng shhfeng 0 Jul 13 02:56 sed.txt

however I execute sed command with --copy 

$ sed -i --copy -e '/test/d' sed.txt

$ ls -l sed.txt

-rw-rw-rw-. 1 root root 0 Jul 13 03:01 sed.txt


but the owner of  /etc/libvirt is root, and attribute is "-rw-r--r--", only root can change this file. so there will be no impact without --copy.

--
To view, visit http://gerrit.ovirt.org/4864
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5c0fe8b86c4fa82bb89d581f594b0dfb9aae425
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list