Change in vdsm[master]: Suppress generating .py{c, o} files when 'make check'

danken at redhat.com danken at redhat.com
Thu Jul 12 09:20:22 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Suppress generating .py{c,o} files when 'make check'
......................................................................


Patch Set 5: Looks good to me, approved

(1 inline comment)

I someone has old garbage in his directory, he may see false results. (both negative and posotive). I can live with this fact for now.

....................................................
File vdsm/storage/Makefile.am
Line 71: 	PYTHONDONTWRITEBYTECODE=1 python $(srcdir)/storage_exception.py
nope, it checks for collisions in error codes.

--
To view, visit http://gerrit.ovirt.org/5934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43ad6301a761ba53c81e505804f3301c526eab6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list