Change in vdsm[master]: Change source of CPU sockets/cores to "/sys" and add cpuThre...

apahim at redhat.com apahim at redhat.com
Wed Jul 11 14:45:24 UTC 2012


Amador Pahim has posted comments on this change.

Change subject: Change source of CPU sockets/cores to "/sys" and add cpuThreads.
......................................................................


Patch Set 4: (8 inline comments)

....................................................
Commit Message
Line 15: systems. Moreover adds the cpuThreads to getVdsCapabilities.
because of flags, mhz and model.

....................................................
File vdsm/caps.py
Line 64:     def __init__(self, cpuinfo='/proc/cpuinfo', \
Done

Line 82:             r = re.compile('^cpu[0-9]+')
Changing to glob, already imported.

Line 95:             # Cleaning the topology due to error.
Done

Line 101:     def siblings(self, cputopology, cpudir, siblingsfile):
I was making the siblings list available. But you're right. No one is going to consume it. Changing to siblings count.

Line 101:     def siblings(self, cputopology, cpudir, siblingsfile):
Done

Line 124:                                                                  self.sockets()
Done

Line 143:             return len(set([p.get('physical id', '0') \
Done

--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list