Change in vdsm[master]: BZ#837443: remove bridge before add VDSM bridge

ilvovsky at redhat.com ilvovsky at redhat.com
Tue Jul 10 11:19:35 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#837443: remove bridge before add VDSM bridge
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File vdsm/configNetwork.py
Line 757:             return
Hmmm, maybe I missed your point, but the whole thing is to 'sync' between libvirt DB and the host status.
So, why exception?

Line 758: 
The only problem I can see is that we may delete the bridge that was created by someone else.
I know that we want to do it in Ovirt case, but what about regular RHEL hosts? 
Is this behavior acceptable?
Dan?

Line 780:     removeLibvirtNetwork(network, log=False)
You already have such check inside the removeLibvirtNetwork

--
To view, visit http://gerrit.ovirt.org/6016
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2842db371483225042d511c6495df1bc5047de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list