Change in vdsm[master]: iscsi: fix update discoverydb with wrong key

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Jul 10 07:05:12 UTC 2012


Mark Wu has posted comments on this change.

Change subject: iscsi: fix update discoverydb with wrong key
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I prefer to remove the following code:
iscsiadm.discoverydb_update(discoverType, iface.name, portalStr, "node.startup", "manual")

Becuase the 'discovery.startup' is set to 'manual' by default in iscsiadm. And it's not actively used by iscsiadm. So we don't need to set it here.

--
To view, visit http://gerrit.ovirt.org/6092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic561c3a69d2f3ec8b5f83b1837e0d126cb5a314a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list