Change in vdsm[master]: BZ#837443: remove bridge before add VDSM bridge
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Tue Jul 10 02:58:14 UTC 2012
Mark Wu has posted comments on this change.
Change subject: BZ#837443: remove bridge before add VDSM bridge
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 757: return
I think you still need raise the exception ERR_BAD_BRIDGE if it's neither a libvirt network nor a bridge name.
--
To view, visit http://gerrit.ovirt.org/6016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2842db371483225042d511c6495df1bc5047de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list