Change in vdsm[master]: Change oop to be a new process instead of a fork

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Jul 9 14:14:34 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Change oop to be a new process instead of a fork
......................................................................


Patch Set 8: (2 inline comments)

....................................................
File tests/outOfProcessTests.py
Line 40:         built in module calls arn't broken"""
s/arn't/aren't

....................................................
File vdsm/storage/outOfProcess.py
Line 29: #GRACE_PERIOD = config.getint("irs", "process_pool_grace_period")
Why keep these in as comments? And if you do, maybe add a comment what they were used for?

--
To view, visit http://gerrit.ovirt.org/4318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65e58030e31fe54b0e79c2f2a415d081f890d41f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dafna Ron <dron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list