Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

ghammer at redhat.com ghammer at redhat.com
Mon Jul 9 12:57:20 UTC 2012


Gal Hammer has posted comments on this change.

Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/vm.py
Line 857:             elif self.guestAgent and self.guestAgent.isResponsive():
I don't agree with this code either. But I do prefer not to review it in this patch. I really prefer to have two patches for this feature. One that add the channel and a second that add the shutdown though qemu ga.

--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list