Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Jul 2 10:40:29 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Do not set max_cstate on host with constant_tsc
......................................................................


Patch Set 2: (1 inline comment)

Do you think it's safe to apply this change to rhel6 based host too?

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 186:             return ' constant_tsc ' in line
I am not sure if new and old cpus could be mixed on one machine. It could happen in a very small chance. So I think we can check the flags for all cpus with just an all() call:

"all([' constant_tsc ' in line for line in file('/proc/cpuinfo') if line.startswith('flags\t')])" 

It is more pythonic :-)

--
To view, visit http://gerrit.ovirt.org/5658
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8473611ff54e19acadb0eb5054de56a928c0dd8c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list