Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Jul 2 08:59:06 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Bingbu,
I think you misunderstood Barak's comment. There's no doubt that we need integrate guest agent shutdown into current shutdown logic, otherwise you patch is useless because it doesn't make sense expose it as a separate api to vdsm client.
What we need get agreement is that the priority of these shutdown methods.
Barak, could you please elaborate your comments a little bit more? Thanks!

....................................................
File vdsm/vm.py
Line 863:             elif utils.tobool(self.conf.get('acpiEnable','true')):
You should create this patch based on the approved commit.

--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list