Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

danken at redhat.com danken at redhat.com
Mon Jul 2 07:35:02 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 2004:     def _qemugaShutdown(self):
who calls this function?

Line 2011:                               self.conf['vmId'])
you most probably do not want to swallow exceptions silently here

....................................................
File vdsm/vm.py
Line 863:             elif utils.tobool(self.conf.get('acpiEnable','true')):
is it related to this patch? please add space after coma.

--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If934c68552888c69c5a971c6f6140f59a9c6acc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list