Change in vdsm[master]: API: Separate clientIF and the xmlrpc server

danken at redhat.com danken at redhat.com
Mon Jan 30 20:47:24 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: API: Separate clientIF and the xmlrpc server
......................................................................


API: Separate clientIF and the xmlrpc server

Currently the xmlrpc server functionality is entwined with the clientIF class.
In order to proceed with the API bridge plan (http://ovirt.org/wiki/Vdsm_API) I
would like to separate the xmlrpc server into its own class.  This brings
clientIF one step closer to becoming a generic API Bridge that is able to host
additional bindings such as REST and QMF.

Despite the size of this patch, this was a pretty simple refactoring.  I made
the following choices as I split this out:

- The xmlrpc server binding class has start() and prepareForShutdown() APIs
- clientIF will still own the storage dispatcher but API wrapper mechanisms
  have moved into the xmlrpc class.

Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Signed-off-by: Adam Litke <agl at us.ibm.com>
---
M vdsm/clientIF.py
M vdsm/vm.py
2 files changed, 167 insertions(+), 112 deletions(-)

Approvals:
  Saggi Mizrahi: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list